Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: poll messages based on messagesTag #2907

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Refactor: poll messages based on messagesTag #2907

merged 1 commit into from
Nov 29, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 28, 2023

What it solves

Resolves #1403

How this PR fixes it

Removes a polling timer and listens to the messagesTag from the backend instead.

How to test it

  • Open the Messages tab
  • In another browser window, create a new message (e.g. OpenSea login)
  • Observe that the new message appeared on the Messages tab within 15 seconds

@katspaugh katspaugh requested a review from iamacook November 28, 2023 17:11
Copy link

github-actions bot commented Nov 28, 2023

Branch preview

✅ Deploy successful!

https://messagestag--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.4 MB (🟡 +810 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/addOwner 3.59 KB (🟡 +2 B) 1.4 MB
/apps 34.59 KB (🟢 -5 B) 1.43 MB
/apps/custom 27.12 KB (🟢 -5 B) 1.42 MB
/home 23.61 KB (🟢 -6 B) 1.42 MB
/new-safe/create 11.83 KB (🟡 +1 B) 1.41 MB
/new-safe/load 7.3 KB (🟡 +12 B) 1.4 MB
/settings/appearance 8.19 KB (🟢 -349 B) 1.4 MB
/settings/setup 24.3 KB (🟡 +2 B) 1.42 MB
/share/safe-app 9.27 KB (🟢 -174 B) 1.41 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.99% 10018/13184
🔴 Branches 50.01% 2029/4057
🔴 Functions 58.81% 1495/2542
🟡 Lines 77.51% 9047/11672

Test suite run success

1097 tests passing in 153 suites.

Report generated by 🧪jest coverage report action from bc98e11

@francovenica
Copy link
Contributor

LGTM.

Opened a Eth safe in 2 browsers, connected to OpenSea.io with WC, signed the message, waited for bit, the message showed up in both browsers in the message tab just fine

Safe used:
https://messagestag--walletweb.review-wallet-web.5afe.dev/transactions/messages?safe=eth:0x8675B754342754A30A2AeF474D114d8460bca19b

@katspaugh katspaugh merged commit bfc561d into dev Nov 29, 2023
14 of 15 checks passed
@katspaugh katspaugh deleted the messagestag branch November 29, 2023 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EIP-1271] Poll messages according to messagesTag
3 participants