Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: custom ENS lookup for Sepolia #2894

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Feat: custom ENS lookup for Sepolia #2894

merged 3 commits into from
Nov 28, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2687.

Ethers v5.7 unfortunately doesn't support Sepolia out of the box, and upgrading to the latest version is complicated.
So as a temporary fix, I'm adding a custom resolver for Sepolia.

Copy link

github-actions bot commented Nov 28, 2023

Branch preview

✅ Deploy successful!

https://sepolia_ens--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 28, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 28, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.4 MB (🟡 +819 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/addOwner 3.59 KB (🟡 +2 B) 1.4 MB
/apps 34.59 KB (🟢 -5 B) 1.43 MB
/apps/custom 27.12 KB (🟢 -5 B) 1.42 MB
/home 23.61 KB (🟢 -6 B) 1.42 MB
/new-safe/create 11.83 KB (🟡 +1 B) 1.41 MB
/new-safe/load 7.3 KB (🟡 +12 B) 1.4 MB
/settings/appearance 8.19 KB (🟢 -349 B) 1.4 MB
/settings/setup 24.3 KB (🟡 +2 B) 1.42 MB
/share/safe-app 9.43 KB (🟢 -6 B) 1.41 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 28, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
76.02% (-0.03% 🔻)
10042/13210
🔴 Branches
50.09% (-0% 🔻)
2038/4069
🔴 Functions
58.88% (-0.02% 🔻)
1499/2546
🟡 Lines
77.55% (-0.03% 🔻)
9070/11696
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.ts
100% 81.82% 100% 100%
🟢
... / config.ts
100% 100% 100% 100%
🔴
... / custom.ts
30.77% 0% 0% 33.33%

Test suite run success

1097 tests passing in 153 suites.

Report generated by 🧪jest coverage report action from 35e58bc

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine when using in our input fields 👍

Are we also able to support it via our wallet object e.g. for displaying the name in the header for a connected wallet?

@katspaugh
Copy link
Member Author

katspaugh commented Nov 28, 2023

No, that would require hacking the provider which I don't think is worth it. Also this PR only adds name resolution, not a reverse lookup.

@francovenica
Copy link
Contributor

Works fine.

ENS sepolia

@katspaugh katspaugh merged commit ffbaa7b into dev Nov 28, 2023
14 of 15 checks passed
@katspaugh katspaugh deleted the sepolia-ens branch November 28, 2023 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Migration to Sepolia]ENS doesn't work on Sepolia
3 participants