-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: custom ENS lookup for Sepolia #2894
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
6506b3d
to
e15c5f8
Compare
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1.4 MB (🟡 +819 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Nine Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/addOwner |
3.59 KB (🟡 +2 B) |
1.4 MB |
/apps |
34.59 KB (🟢 -5 B) |
1.43 MB |
/apps/custom |
27.12 KB (🟢 -5 B) |
1.42 MB |
/home |
23.61 KB (🟢 -6 B) |
1.42 MB |
/new-safe/create |
11.83 KB (🟡 +1 B) |
1.41 MB |
/new-safe/load |
7.3 KB (🟡 +12 B) |
1.4 MB |
/settings/appearance |
8.19 KB (🟢 -349 B) |
1.4 MB |
/settings/setup |
24.3 KB (🟡 +2 B) |
1.42 MB |
/share/safe-app |
9.43 KB (🟢 -6 B) |
1.41 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Test suite run success1097 tests passing in 153 suites. Report generated by 🧪jest coverage report action from 35e58bc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine when using in our input fields 👍
Are we also able to support it via our wallet
object e.g. for displaying the name in the header for a connected wallet?
No, that would require hacking the provider which I don't think is worth it. Also this PR only adds name resolution, not a reverse lookup. |
What it solves
Resolves #2687.
Ethers v5.7 unfortunately doesn't support Sepolia out of the box, and upgrading to the latest version is complicated.
So as a temporary fix, I'm adding a custom resolver for Sepolia.