Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seedless Onboarding]: Adjust password form #2692

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 25, 2023

What it solves

Part of #2452

How this PR fixes it

  • Renames oldPassword to currentPassword
  • Renames Confirm new password to Confirm password
  • Displays a submit error inside the form
  • Fixes z-index issue on the settings page when scrolling
  • Adds an event to track create safe form cancels
  • Adds visual default states for passwordStrength and passwordsMatch
  • Closes the accordion on successful form submission

How to test it

  1. Open a Safe and login with google
  2. Go to the settings page
  3. Compare form design with Figma

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from schmanu October 25, 2023 10:49
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Branch preview

✅ Deploy successful!

https://adjust_password_form--walletweb.review-wallet-web.5afe.dev

@usame-algan usame-algan changed the title Adjust password form [Seedless Onboarding]: Adjust password form Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.57% (-0.07% 🔻)
9461/12688
🔴 Branches
48.64% (-0.11% 🔻)
1897/3900
🔴 Functions
56.48% (-0.05% 🔻)
1382/2447
🟡 Lines
76.09% (-0.06% 🔻)
8551/11238
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / helper.ts
30% (-1.25% 🔻)
0% 0%
29.63% (-1.4% 🔻)
🔴
... / index.tsx
46.97% (-10.44% 🔻)
19.35% (-7.92% 🔻)
30% (-7.5% 🔻)
50% (-10% 🔻)

Test suite run success

1007 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from d8775d1

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks and works well 💯

One small suggestion:
When pressing the Cancel button inside the Change Password dialog I'd consider closing the Accordion.

@usame-algan usame-algan merged commit 748b145 into web3authcoresdk Oct 26, 2023
7 of 8 checks passed
@usame-algan usame-algan deleted the adjust-password-form branch October 26, 2023 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants