-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Seedless Onboarding]: Adjust password form #2692
Conversation
Branch preview✅ Deploy successful! https://adjust_password_form--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
3cc7351
to
9b77c84
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1007 tests passing in 143 suites. Report generated by 🧪jest coverage report action from d8775d1 |
e4662bc
to
d8775d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks and works well 💯
One small suggestion:
When pressing the Cancel button inside the Change Password dialog I'd consider closing the Accordion.
What it solves
Part of #2452
How this PR fixes it
oldPassword
tocurrentPassword
Confirm new password
toConfirm password
passwordStrength
andpasswordsMatch
How to test it
Checklist