fix: do not offer executing unsigned txs with connected wallet (#4598)

Co-authored-by: Aaron Cook <aaron@safe.global>
safe-global · Dec 10, 2024 · ac4de7a · ac4de7a
1 parent c3d7922
commit ac4de7a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/components/tx/SignOrExecuteForm/SignerForm/index.tsx b/src/components/tx/SignOrExecuteForm/SignerForm/index.tsx
@@ -58,13 +58,14 @@ export const SignerForm = ({ willExecute }: { willExecute?: boolean }) => {
       return []
     }
     const owners = new Set(nestedSafeOwners ?? [])
+    const isFullySigned = safeTx ? safeTx.signatures.size >= safe.threshold : false
 
-    if (willExecute || safe.owners.some((owner) => sameAddress(owner.value, wallet.address))) {
+    if ((willExecute && isFullySigned) || safe.owners.some((owner) => sameAddress(owner.value, wallet.address))) {
       owners.add(wallet.address)
     }
 
     return Array.from(owners)
-  }, [nestedSafeOwners, safe.owners, wallet, willExecute])
+  }, [nestedSafeOwners, safe.owners, safe.threshold, safeTx, wallet, willExecute])
 
   if (!wallet || !isNestedOwner) {
     return null