Refactor Safe interface to ISafeTest for test usage. #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add GitHub Actions workflow for safe-modules-allowance * Update package.json scripts for linting and formatting * Update import statements in test helpers to use ISafeTest
mmv08
requested review from
nlordell,
akshay-ap and
remedcu
and removed request for
a team
remedcu
approved these changes
Aug 30, 2024
akshay-ap
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was needed to fix the allowance module tests broken by the interface name collision introduced in #489, also with the GitHub action we're less likely to break the tests again