Use Slightly More Gas For 4337 Test #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under certain conditions, an E2E test can fail because it uses slightly more gas. This PR adds a larger gas buffer to the E2E test to prevent intermittent failures.
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
nlordell
commented
Jul 18, 2024
| @@ -59,7 +59,7 @@ contract Account is Safe { | |||
| * The canonical format ensures the signatures are tightly packed one after the other in order. | |||
| * | |||
| * For more details on signature encoding: https://docs.safe.global/advanced/smart-account-signatures | |||
| */ | |||
| */ | |||
There was a problem hiding this comment.
Unrelated formatting changes from running prettier on the project.
Pull Request Test Coverage Report for Build 9991309758Details
💛 - Coveralls |
remedcu
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions, an E2E test can fail because it uses slightly more gas. This PR adds a larger gas buffer to the E2E test to prevent intermittent failures.
Example failure: https://github.com/safe-global/safe-modules/actions/runs/9990468990/job/27611219692