Code

Signature length check#453

Code

Merged

akshay-ap merged 52 commits intomainsafe-global/safe-modules:mainfrom fix-754-signature-length-checksafe-global/safe-modules:fix-754-signature-length-checkCopy head branch name to clipboardJul 12, 2024

+550-10

Commits

Commits on Jul 1, 2024

• [#754] WIP: Signature length check

  akshay-ap

  committed
  9c9136b

  Copy full SHA for 9c9136b

• [#754] Update comment in SafeL2Mod

  akshay-ap

  committed
  c512034

  Copy full SHA for c512034

Commits on Jul 4, 2024

• [#754] Add signature length checks in Safe4337Module

  akshay-ap

  committed
  6ffaaf8

  Copy full SHA for 6ffaaf8

• [#754] Fix lint issues

  akshay-ap

  committed
  78ef010

  Copy full SHA for 78ef010

• [#754] Summarize _checkSignatureLength function

  akshay-ap

  committed
  f61aec6

  Copy full SHA for f61aec6

• [#754] Update comment

  akshay-ap

  committed
  c72d37f

  Copy full SHA for c72d37f

• [#754] Remove commented code

  akshay-ap

  committed
  7fc14c1

  Copy full SHA for 7fc14c1

• [#754] Use calldataload instruction

  akshay-ap

  committed
  2754975

  Copy full SHA for 2754975

• [#754] Fixes

  akshay-ap

  committed
  032c7a3

  Copy full SHA for 032c7a3

• [#754] Fixes

  akshay-ap

  committed
  17e6d46

  Copy full SHA for 17e6d46

• [#754] Update tests

  akshay-ap

  committed
  9e22daf

  Copy full SHA for 9e22daf

Commits on Jul 8, 2024

• Update modules/4337/certora/specs/Safe4337Module.spec

  Show description for dd43fe3
  

  akshay-ap

  and

  nlordell

  authored
  dd43fe3

  Copy full SHA for dd43fe3

• Update modules/4337/certora/specs/ValidationDataLastBitOne.spec

  Show description for d5cb574
  

  akshay-ap

  and

  nlordell

  authored
  d5cb574

  Copy full SHA for d5cb574

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for fce0584
  

  akshay-ap

  and

  nlordell

  authored
  fce0584

  Copy full SHA for fce0584

• [#754] Add comment on signature encoding in _checkSignatureLength

  akshay-ap

  committed
  9e526d6

  Copy full SHA for 9e526d6

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for 8450bb7
  

  akshay-ap

  and

  nlordell

  authored
  8450bb7

  Copy full SHA for 8450bb7

• [#754] Update gas estimates and fix compilation error

  akshay-ap

  committed
  9c131c6

  Copy full SHA for 9c131c6

• [#754] Fix lint issue

  akshay-ap

  committed
  c8702f6

  Copy full SHA for c8702f6

• [#754] Adjust signature check logic

  akshay-ap

  committed
  d83e133

  Copy full SHA for d83e133

• [#754] Update comment, adjust _validateSignatures

  akshay-ap

  committed
  affd342

  Copy full SHA for affd342

• Update modules/4337/certora/specs/ValidationDataLastBitOne.spec

  Show description for 9047334
  

  akshay-ap

  and

  remedcu

  authored
  9047334

  Copy full SHA for 9047334

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for 001c6ce
  

  akshay-ap

  and

  remedcu

  authored
  001c6ce

  Copy full SHA for 001c6ce

• [#754] Rename variables, add comments

  akshay-ap

  committed
  af3b708

  Copy full SHA for af3b708

• [#754] Lint fix

  akshay-ap

  committed
  d8ba708

  Copy full SHA for d8ba708

Commits on Jul 9, 2024

• [#754] Add tests

  akshay-ap

  committed
  22fc197

  Copy full SHA for 22fc197

• [#754] Rename variable

  akshay-ap

  committed
  53345a6

  Copy full SHA for 53345a6

• [#754] Update comment

  akshay-ap

  committed
  1c31fda

  Copy full SHA for 1c31fda

• Update modules/4337/test/erc4337/ERC4337ModuleNew.spec.ts

  Show description for 195f792
  

  akshay-ap

  and

  remedcu

  authored
  195f792

  Copy full SHA for 195f792

Commits on Jul 10, 2024

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for 3975d8f
  

  akshay-ap

  and

  nlordell

  authored
  3975d8f

  Copy full SHA for 3975d8f

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for 16c7b8b
  

  akshay-ap

  and

  nlordell

  authored
  16c7b8b

  Copy full SHA for 16c7b8b

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for 3a37597
  

  akshay-ap

  and

  nlordell

  authored
  3a37597

  Copy full SHA for 3a37597

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for 5fa8afd
  

  akshay-ap

  and

  nlordell

  authored
  5fa8afd

  Copy full SHA for 5fa8afd

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for c2a0770
  

  akshay-ap

  and

  nlordell

  authored
  c2a0770

  Copy full SHA for c2a0770

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for e7c2348
  

  akshay-ap

  and

  nlordell

  authored
  e7c2348

  Copy full SHA for e7c2348

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for 3ef2a22
  

  akshay-ap

  and

  nlordell

  authored
  3ef2a22

  Copy full SHA for 3ef2a22

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for db87077
  

  akshay-ap

  and

  nlordell

  authored
  db87077

  Copy full SHA for db87077

• [#754] Update Natspec

  akshay-ap

  committed
  f7ecfc6

  Copy full SHA for f7ecfc6

• [#754] Update comments in _checkSignatureLength

  akshay-ap

  committed
  979b6a4

  Copy full SHA for 979b6a4

• [#754] Update variable name to expectedOffset

  akshay-ap

  committed
  ca9e575

  Copy full SHA for ca9e575

• [#754] Add tests

  akshay-ap

  committed
  1ec9813

  Copy full SHA for 1ec9813

Commits on Jul 11, 2024

• Update modules/4337/contracts/Safe4337Module.sol

  Show description for be6a6f5
  

  akshay-ap

  and

  nlordell

  authored
  be6a6f5

  Copy full SHA for be6a6f5

• [#754] Rename function, remove if-else

  akshay-ap

  committed
  2743e53

  Copy full SHA for 2743e53

• [#754] Update comment on fixed signature part

  akshay-ap

  committed
  025234f

  Copy full SHA for 025234f

• [#754] Run tests

  akshay-ap

  committed
  c54c89d

  Copy full SHA for c54c89d

• Update modules/4337/test/erc4337/ReferenceEntryPoint.spec.ts

  Show description for db5fcba
  

  akshay-ap

  and

  nlordell

  authored
  db5fcba

  Copy full SHA for db5fcba

• Update modules/4337/test/erc4337/ReferenceEntryPoint.spec.ts

  Show description for ab66109
  

  akshay-ap

  and

  nlordell

  authored
  ab66109

  Copy full SHA for ab66109

• Update modules/4337/test/erc4337/ReferenceEntryPoint.spec.ts

  Show description for 31798cb
  

  akshay-ap

  and

  nlordell

  authored
  31798cb

  Copy full SHA for 31798cb

• [#754] Update test

  akshay-ap

  committed
  42b216e

  Copy full SHA for 42b216e

• [#754] Update tests

  akshay-ap

  committed
  0306c39

  Copy full SHA for 0306c39

• Refactor Length Check Implementation

  Show description for 16e7b14
  nlordell

  committed
  16e7b14

  Copy full SHA for 16e7b14

• Cleanup Post-Review

  nlordell

  committed
  405a5ba

  Copy full SHA for 405a5ba

Commits on Jul 12, 2024

• [#754] Lint fix

  akshay-ap

  committed
  09c4000

  Copy full SHA for 09c4000