Fix Precompile Address Width #396
Merged
+58
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
remedcu
approved these changes
Apr 22, 2024
|
cc @akshay-ap and @mmv08 as this changes the function signature yet again 🙈. I can wait for you to merge your PRs so I can make sure that I don't break anything (I think there is a small needed adjustment in the proxy implementation for example). |
|
@nlordell there are some merge conflicts. |
nlordell
force-pushed
the
fix-verifiers-range
branch
from
3a3e66b to
5104cc1
Compare
Pull Request Test Coverage Report for Build 8920797342Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking through the code, I realized that I made a mistake in #379. Specifically, we specify that precompiles fit into a
uint32, when in fact they fit into auint16:https://eips.ethereum.org/EIPS/eip-1352
This PR changes the code to encode the
P256.Verifierstype to be auint16 || addressinstead of a slightly largeruint32.Alternatively, we could use a full 96 bits to represent the precompile address and make
P256.Verifiersauint256(this has a small positive effect on gas usage and code size, as it gets rid of compiler generated masking code).