Rename Workspace Packages #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
nlordell
force-pushed
the
chore/refactor-monorepo-1
branch
from
7816091 to
93a7c4f
Compare
Pull Request Test Coverage Report for Build 8187424442Details
💛 - Coveralls |
nlordell
force-pushed
the
chore/refactor-monorepo-1
branch
from
93a7c4f to
deda8af
Compare
nlordell
force-pushed
the
chore/refactor-monorepo-1
branch
from
deda8af to
aa5b37e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just renames some workspace packages to be (hopefully) more consistent:
safe-4337-passkeyexample is now4337-passkey. Since the path wassafe-global/safe-modules/examples/safe-4337-passkey, it felt like the lastsafewas already implicit...package.jsonnames to include thesafe-modules-example-prefix (kind of like scoping). Since they are private packages, it doesn't really matter.safe-erc4337->safe-4337, it is more succinct and IMO the ERC is superfluous in the package name.Additionally, I added the missing example to the root
README.