Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Recovery banner #256

Merged
merged 4 commits into from
Dec 7, 2023
Merged

feat: Recovery banner #256

merged 4 commits into from
Dec 7, 2023

Conversation

DiogoSoaress
Copy link
Member

What it solves

Adds a banner to announce and link resources to the RecoveryHub

Figma

https://www.figma.com/file/Y3l2Y4UY6WsdOJrqKjN3J1/Web-Graphics?type=design&node-id=2927-109&mode=design&t=3bPDSZ6HRQhpfOPr-4

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

Branch preview

✅ Deployed to dev:

https://safe-web-landing.dev.5afe.dev

katspaugh
katspaugh reviewed Dec 7, 2023
View reviewed changes
public/images/Wallet/buoy.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run it through tinypng again? Sometimes running a few times gives better results (with diminishing returns).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a nice tip!
I've run it a couple times more but the spotlight in behind the image loses some quality (lines start to show) in exchange of 10KB. I'd think it's not worth in this case as it is more evident in the dark background. WDYT?

I will remember this for future png images tho. I feel we have many images that could be further optimized.

katspaugh
katspaugh reviewed Dec 7, 2023
View reviewed changes
src/content/wallet.json Outdated
},
{
"text": "Read more",
"href": "",
Copy link
Member

@katspaugh katspaugh Dec 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dis tbd?
Edit: just noticed it's a draft PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes yes. Waiting for the blog URL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@DiogoSoaress DiogoSoaress marked this pull request as ready for review December 7, 2023 10:57
@DiogoSoaress DiogoSoaress merged commit 734ec2c into main Dec 7, 2023
5 checks passed
@DiogoSoaress DiogoSoaress deleted the banner-recovery branch December 7, 2023 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiogoSoaress @katspaugh