feat: inline play Hero videos #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Branch preview✅ Deployed to dev: |
DiogoSoaress
force-pushed
the
inline-hero-videos
branch
4 times, most recently
from
e043a2e to
7a9be86
Compare
DiogoSoaress
force-pushed
the
inline-hero-videos
branch
2 times, most recently
from
17bf328 to
8dca8fb
Compare
DiogoSoaress
force-pushed
the
inline-hero-videos
branch
from
8dca8fb to
e75cecc
Compare
mmv08
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Keeps the videos from playing in a fullscreen modal disrupting the mobile experience.
How this PR fixes it
playsInlineattribute to the<video>tag..mp4files, keeping only webm with a .hevc.mp4 fallback./Corefolder.How to test
Navigate from https://safe-web-landing.dev.5afe.dev/ to https://safe-web-landing.dev.5afe.dev/core in a mobile browser and observe the Intro videos playing in the layout rather than in fullscreen