feat: Track "Social Login" campaign #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Branch preview✅ Deployed to dev: |
katspaugh
approved these changes
Nov 22, 2023
katspaugh
reviewed
Nov 22, 2023
src/services/analytics/trackEvent.ts
Outdated
| import ReactGA from 'react-ga4' | ||
| import type { UaEventOptions } from 'react-ga4/types/ga4' | ||
|
|
||
| export const trackEvent = (eventData: UaEventOptions | string) => { |
There was a problem hiding this comment.
Good catch. I've copied it over from the types definition file but we don't use it as a string ever. Removed it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Adds tracking to the "Social Login" campaign page according to the shared doc
How this PR fixes it
Notes
I could only test the events were being received in our analytics dashboard by modifying
useGa.tslocally. This hook initializes ReactGA4.