Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chains retrieval and cache deletion debug logs #1786

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This PR adds optional logs to the retrieval/cache deletion of Chain objects from the Safe Config Service.

Changes

  • Adds a feature flag to control Chain-related debugging logs: configHooksDebugLogs.
  • Adds optional logging to ConfigApi when the clearChain function is executed (after the reception of a CHAIN_UPDATED event).
  • Adds optional logging to CacheFirstDatasource when the chain/chains cache key is written in the cache.

@hectorgomezv hectorgomezv self-assigned this Jul 24, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner July 24, 2024 16:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10080178428

Details

  • 7 of 11 (63.64%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 48.457%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/datasources/cache/cache.first.data.source.ts 2 4 50.0%
src/datasources/config-api/config-api.service.ts 5 7 71.43%
Totals Coverage Status
Change from base Build 10054294132: 0.003%
Covered Lines: 4332
Relevant Lines: 7207

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit fb8d3fd into main Jul 26, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the config-service-events-log branch July 26, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants