Add domain logic for push notifications #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
force-pushed
the
notifications-domain
branch
from
b803411 to
17838ac
Compare
iamacook
commented
Jul 23, 2024
Comment on lines
47
to
122
| if (safe && safe.owners.includes(args.account)) { | ||
| authorizedSafesToSubscribe.push(safeToSubscribe); | ||
| continue; | ||
| } | ||
|
|
||
| const delegates = await this.delegatesRepository | ||
| .getDelegates({ | ||
| chainId: safeToSubscribe.chainId, | ||
| safeAddress: safeToSubscribe.address, | ||
| delegate: args.account, | ||
| }) | ||
| .catch(() => null); | ||
|
|
||
| // Upsert delegate | ||
| if ( | ||
| delegates && | ||
| delegates.results.some(({ delegate }) => delegate === args.account) |
There was a problem hiding this comment.
These checks need to be disucssed as it is still unclear whether we allow anyone to subscribe to queue-related events. I'd suggest we keep with owner/delegate only and adjust later if needed as it's a small adjustment if necessary.
iamacook
force-pushed
the
notifications-domain
branch
from
360de40 to
8bae9d4
Compare
iamacook
force-pushed
the
notifications-domain
branch
from
a14ce77 to
b59e7f7
Compare
hectorgomezv
approved these changes
Jul 26, 2024
Comment on lines
636
to
640
| subscribers.map((subscriber) => { | ||
| return messageConfirmationBuilder() | ||
| .with('owner', subscriber.subscriber) | ||
| .build(); | ||
| }), |
There was a problem hiding this comment.
Nit: should we also test the scenario where a subset of the subscribers have signed? I think currently all the test escenarios are all-or-none signatures.
| continue; | ||
| } | ||
|
|
||
| throw new UnauthorizedException(); |
There was a problem hiding this comment.
Nit: should we log this error (the account signer not being a owner/delegate of one of the target Safes), wdyt?
hectorgomezv
approved these changes
Jul 30, 2024
|
I think this PR needs a rebase onto the source branch 🙂 |
hectorgomezv
previously approved these changes
Aug 5, 2024
hectorgomezv
approved these changes
Aug 6, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Leverages the `NotificationsDatasource` to `getSubscribersWithTokensBySafe` for the relative `TransactionEventType` and `enqueueNotification`s accordingly: - Add `INotificationsRepositoryV2` behind a feature flag: - `enqueueNotification` - `upsertSubscriptions` - `getSafeSubscription` - `getSubscribersWithTokensBySafe` - `deleteSubscription` - `deleteDevice` - Extend `HooksRepository` with `onEventEnqueueNotifications` with respective entities. - Add `transaction_hash` query to `getIncomingTransfers` and propagate changes/add tests. - Locate previously domain-relative logic for notifications in domain, e.g. entities and builders. - Add approriate test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the relative logic to the domain for enqueuing notifications to subscribers when the relevant hook event is received.
It leverages the
NotificationsDatasourcetogetSubscribersWithTokensBySafefor the relativeTransactionEventTypeandenqueueNotifications accordingly.Changes
INotificationsRepositoryV2behind a feature flag:enqueueNotificationupsertSubscriptionsgetSafeSubscriptiongetSubscribersWithTokensBySafedeleteSubscriptiondeleteDeviceHooksRepositorywithonEventEnqueueNotificationswith respective entities.transaction_hashquery togetIncomingTransfersand propagate changes/add tests.