Decouple notifications from account in datasource

safe-global · Jul 30, 2024 · 8badc91 · 8badc91
1 parent c63bf4a
commit 8badc91
Show file tree

Hide file tree

Showing 5 changed files with 334 additions and 237 deletions.
diff --git a/src/datasources/accounts/notifications/__tests__/upsert-subscriptions.dto.entity.builder.ts b/src/datasources/accounts/notifications/__tests__/upsert-subscriptions.dto.entity.builder.ts
@@ -9,7 +9,6 @@ import { NotificationType } from '@/domain/notifications/entities-v2/notificatio
 // TODO: Move to domain
 export function upsertSubscriptionsDtoBuilder(): IBuilder<UpsertSubscriptionsDto> {
   return new Builder<UpsertSubscriptionsDto>()
-    .with('account', getAddress(faker.finance.ethereumAddress()))
     .with('cloudMessagingToken', faker.string.alphanumeric({ length: 10 }))
     .with('deviceType', faker.helpers.arrayElement(Object.values(DeviceType)))
     .with('deviceUuid', faker.string.uuid() as Uuid)

diff --git a/src/datasources/accounts/notifications/entities/upsert-subscriptions.dto.entity.ts b/src/datasources/accounts/notifications/entities/upsert-subscriptions.dto.entity.ts
@@ -4,7 +4,6 @@ import { Uuid } from '@/domain/notifications/entities-v2/uuid.entity';
 
 // TODO: Move to domain
 export type UpsertSubscriptionsDto = {
-  account: `0x${string}`;
   cloudMessagingToken: string;
   safes: Array<{
     chainId: string;