Add further test coverage

safe-global · Jul 25, 2024 · 2d18898 · 2d18898
1 parent 0f116c8
commit 2d18898
Show file tree

Hide file tree

Showing 4 changed files with 790 additions and 173 deletions.
diff --git a/src/domain/notifications/notifications.repository.v2.ts b/src/domain/notifications/notifications.repository.v2.ts
@@ -160,7 +160,12 @@ export class NotificationsRepositoryV2 implements INotificationsRepositoryV2 {
       throw new UnauthorizedException();
     }
 
-    return this.notificationsDatasource.getSafeSubscription(args);
+    return this.notificationsDatasource.getSafeSubscription({
+      account: args.account,
+      deviceUuid: args.deviceUuid,
+      chainId: args.chainId,
+      safeAddress: args.safeAddress,
+    });
   }
 
   // Note: no authentication required as not controller focused
@@ -190,7 +195,12 @@ export class NotificationsRepositoryV2 implements INotificationsRepositoryV2 {
       throw new UnauthorizedException();
     }
 
-    return this.notificationsDatasource.deleteSubscription(args);
+    return this.notificationsDatasource.deleteSubscription({
+      account: args.account,
+      deviceUuid: args.deviceUuid,
+      chainId: args.chainId,
+      safeAddress: args.safeAddress,
+    });
   }
 
   deleteDevice(args: {

diff --git a/src/routes/accounts/notifications/entities/__tests__/upsert-subscriptions-dto.entity.spec.ts b/src/routes/accounts/notifications/entities/__tests__/upsert-subscriptions-dto.entity.spec.ts
@@ -73,7 +73,7 @@ describe('UpsertSubscriptionsDtoSchema', () => {
     expect(!result.success && result.error.issues).toStrictEqual([
       {
         code: 'invalid_string',
-        message: 'Invalid uuid',
+        message: 'Invalid UUID',
         path: ['deviceUuid'],
         validation: 'uuid',
       },