-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for executing transactions in scripting mode #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
I was considered additionally that the purpose of this PR, in addition to the "attended-mode" was to support scripting. In that case I think having a --no-input
flag or similar should be added (initially to the commands that require it but in the future for it to be a global parameter).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👏 👏 👏
Closes #36
Points of interest:
send_ether
,send-erc20
,send-erc721
,send-custom
andtx-builder
commands. The first commands allow to execute transactions and the second, by importing a file generated by the tx_builder, can execute tx batches using the MultiSendCallOnly contract.The logic of theAdded here: Add support for executing transactions from tx-builder json file #426tx_builder_file_decoder
is developed based on what I know is done in the front end tx_builder.script_mode
no_input
property is added tosafe_operator
to raise exceptions that terminate execution instead of just displaying the error message (prompt mode).Readme
file with the examples of the added commands.