Fix update not working for Safes > 1.1.1 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Uxio0
commented
Nov 6, 2023
Uxio0
commented
- Update master copy function was removed after 1.1.1
- Migration contracts to update from 1.3.0 to 1.4.1 are still not available
- Test update
- Update master copy function was removed after 1.1.1 - Migration contracts to update from 1.3.0 to 1.4.1 are still not available - Test update
moisses89
requested changes
Nov 7, 2023
| ) | ||
| self.assertEqual( | ||
| safe_operator_v111.safe.retrieve_fallback_handler(), | ||
| last_default_fallback_handler_address.return_value, |
There was a problem hiding this comment.
Suggested change
| last_default_fallback_handler_address.return_value, | |
| last_default_fallback_handler_address.return_value |
|
|
||
| self.assertEqual( | ||
| safe_operator_v111.safe.retrieve_master_copy_address(), | ||
| last_safe_contract_address_mock.return_value, |
There was a problem hiding this comment.
last_safe_contract_address_mock.return_value is safe_contract_V1_4_1.address, then the v1.1.1 was updated to 1.4.1 this is possible?
moisses89
approved these changes
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.