Add update_to_l2 command #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Uxio0
commented
Nov 3, 2023
•
Uxio0
commented
- Updates a v1.1.1/v1.3.0/v1.4.1 non L2 Safe to a L2 Safe supported by Safe Wallet UI. The migration contract address needs to be provided. It can be found here.
- Nonce for the Safe must be 0 and supported versions are v1.1.1, v1.3.0 and v1.4.1.
- Related to Support L2 Safes upgraded from non L2 Safes safe-transaction-service#1703
- Closes Add migration upgrade from non L2 Safes to L2 Safes #285
Updates a v1.1.1/v1.3.0/v1.4.1 non L2 Safe to a L2 Safe supported by Safe Wallet UI. The migration contract address needs to be provided. It can be found [here](https://github.com/safe-global/safe-contracts/blob/main/contracts/libraries/SafeToL2Migration.sol). Nonce for the Safe must be 0 and supported versions are v1.1.1, v1.3.0 and v1.4.1.
moisses89
reviewed
Nov 3, 2023
| if self.safe.retrieve_nonce() > 0: | ||
| raise InvalidNonceException("Nonce must be 0 for non L2 to L2 migration") | ||
|
|
||
| if safe_version == "1.1.1": |
There was a problem hiding this comment.
In case of 1.1.1 the idea is to update to 1.3.0 L2?
moisses89
reviewed
Nov 3, 2023
| @@ -0,0 +1,165 @@ | |||
| safe_to_l2_migration = { | |||
| "_format": "hh-sol-artifact-1", | |||
| "contractName": "SafeToL2Migration", | |||
There was a problem hiding this comment.
Maybe can be better move this file to a contracts folder, utils is very generic.
There was a problem hiding this comment.
Yes, I'm thinking that this might belong to safe-eth-py
moisses89
approved these changes
Nov 6, 2023
|
|
||
| if not self.ethereum_client.is_contract(migration_contract_address): | ||
| raise InvalidMigrationContractException( | ||
| f"Non L2 to L2 migration contract {migration_contract_address} is not deployed" |
There was a problem hiding this comment.
I think that is not necessary specify the origin contract, for me is more clear
Suggested change
| f"Non L2 to L2 migration contract {migration_contract_address} is not deployed" | |
| f"L2 migration contract {migration_contract_address} is not deployed" |
| }, | ||
| } | ||
| }, | ||
| ): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.