Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Complex sum for floats does not vectorize because real and imaginary are interleaved. This uses an intermediate data type during sum to vectorize the sum. There is no unsafe, and on my computer I get almost a 4x speed improvement for f32:
I made a repo if you want to test the results yourself: https://github.com/michaelciraci/num-complex-simd-comparison
This however would technically be a breaking change, due to the order that the floats are summed (float1 + float2 + float3 may not equal float3 + float2 + float1).
This however might be an opportunity to have an SIMD feature for floats.
I waited to implement SIMD product to see what route you wanted to go down (if you were interested at all).