Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci update freebsd version proposal, freebsd 12 being eol. #135105

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Jan 4, 2025

raising to the lowest still active supported freebsd version. From 13.1 (already eol too), freebsd introduces a cpu affinity layer with linux. It also introduces a api compatible copy_file_range which can be used like its linux's counterpart.
The former is essential to build #120589, therefore breaks the backward compatibility with the previous FreeBSD releases.

TBD: updating path for 13.3 binaries in src/ci/docker/scripts/freebsd-toolchain.sh

raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build rust-lang#120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.

TBD: updating path for 13.3 binaries in src/ci/docker/scripts/freebsd-toolchain.sh
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 4, 2025
@devnexen
Copy link
Contributor Author

devnexen commented Jan 4, 2025

cc @asomers

Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using FreeBSD 13.2 won't work due to an LLVM bug. See #132185 for details. Also, see #132232 for a PR which includes most of what this one does.

@devnexen
Copy link
Contributor Author

devnexen commented Jan 4, 2025

Using FreeBSD 13.2 won't work due to an LLVM bug. See #132185 for details. Also, see #132232 for a PR which includes most of what this one does.

Ah did not know about 13.3 being so close. ok closing then.

@devnexen devnexen closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants