add m68k-unknown-none-elf target #135085

knickish · 2025-01-03T20:27:54Z

The existing m68k-unknown-linux-gnu target builds std by default, requires atomics, and has a base cpu with an fpu. A smaller/more embedded target is desirable both to have a baseline target for the ISA, as well to make debugging easier for working on the llvm backend. Currently this target is using the M68010 as the minimum CPU due, but as missing features are merged into the M68k llvm backend I am hoping to lower this further.

I have been able to build very small crates using a toolchain built against this target (together with a later version of object) using the configuration described in the target platform-support documentation, although getting anything of substantial complexity to build quickly hits errors in the llvm backend

rustbot · 2025-01-03T20:28:02Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-01-03T20:50:07Z

Could not assign reviewer from: workingjubilee.
User(s) workingjubilee are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

rustbot · 2025-01-03T21:28:00Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

workingjubilee · 2025-01-03T21:32:53Z

@knickish Have you read and understand the terms of https://doc.rust-lang.org/nightly/rustc/target-tier-policy.html#tier-3-target-policy regarding target maintenance?

Briefly put: The ticket is free because the ride ain't got no safeties, no brakes, and no complaining.

knickish · 2025-01-03T21:53:31Z

@workingjubilee Yup, got it. Don't break anybody, and any higher tier target can break me.

Should I just remove the endianness compiletest that seems to require the target to already be in the bootstrap compiler?

workingjubilee

mostly typo nits, don't worry much about them, I just woke up in copyeditor mode today. mostly concerned about the ABI-related stuff and the consent.

src/doc/rustc/src/platform-support/m68k-unknown-none-elf.md

workingjubilee · 2025-01-03T21:46:29Z

src/doc/rustc/src/platform-support/m68k-unknown-none-elf.md

+$ qemu-m68k-static your-code
+```
+
+For more complex applications, a chroot or native m68k system is required for testing.


thinks ...well, Amigas don't have USB, so how am I gonna get my program from a modern, made-in-2024 dev computer to the Amiga? ...hmm, I can still find a 5.25 bay, and I can get a floppy drive, I guess? I know there's some adapters that let you drive them via USB, too... hope it's less than 1.44MB...

anyways, that all is pretty squarely in Their Problem territory, but I do have one question that this thing should probably answer: would just copying the program to the floppy be sufficient, or should I do something else first?

I'm pretty sure that just copying it should be sufficient. It's just linux on a different arch, so as long as you cross compile it should be good to go.

hm, for the bare metal target?

but yeah sounds good then.

workingjubilee · 2025-01-03T21:51:59Z

src/doc/rustc/src/platform-support/m68k-unknown-none-elf.md

+[target.m68k-unknown-none-elf]
+# there is no easily available non-linux m68k linker, so just use the linux one
+linker = "m68k-linux-gnu-ld"


Is this section necessary, given we already set this in the TargetOptions? Maybe this should just be

Suggested change

[target.m68k-unknown-none-elf]

# there is no easily available non-linux m68k linker, so just use the linux one

linker = "m68k-linux-gnu-ld"

src/tools/compiletest/src/header/tests.rs

compiler/rustc_target/src/spec/targets/m68k_unknown_none_elf.rs

Co-authored-by: Jubilee <workingjubilee@gmail.com>

workingjubilee

then just waiting on affirmation from the other maintainers.

Co-authored-by: Jubilee <workingjubilee@gmail.com>

knickish · 2025-01-05T16:59:34Z

I've gone ahead and removed them, can add them back later if they want to be involved.

workingjubilee · 2025-01-05T19:05:20Z

Good enough for me!

@bors r+ rollup

bors · 2025-01-05T19:05:23Z

📌 Commit f985a37 has been approved by workingjubilee

It is now in the queue for this repository.

knickish · 2025-01-05T19:16:20Z

Thanks for the review!

…ingjubilee add m68k-unknown-none-elf target r? `@workingjubilee` The existing `m68k-unknown-linux-gnu` target builds `std` by default, requires atomics, and has a base cpu with an fpu. A smaller/more embedded target is desirable both to have a baseline target for the ISA, as well to make debugging easier for working on the llvm backend. Currently this target is using the `M68010` as the minimum CPU due, but as missing features are merged into the `M68k` llvm backend I am hoping to lower this further. I have been able to build very small crates using a toolchain built against this target (together with a later version of `object`) using the configuration described in the target platform-support documentation, although getting anything of substantial complexity to build quickly hits errors in the llvm backend

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-01-06T05:23:58Z

⌛ Testing commit f985a37 with merge fd98df8...

Rollup of 4 pull requests Successful merges: - rust-lang#135085 (add m68k-unknown-none-elf target) - rust-lang#135111 (Add doc aliases for `libm` and IEEE names) - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`) - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler) r? `@ghost` `@rustbot` modify labels: rollup try-job: dist-aarch64-apple

bors · 2025-01-06T08:07:05Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing fd98df8 to master...

rustbot assigned GuillaumeGomez Jan 3, 2025

This comment has been minimized.

Sign in to view

knickish force-pushed the m68k_unknown_none branch from 3de409d to 96add89 Compare January 3, 2025 20:45

knickish force-pushed the m68k_unknown_none branch from 96add89 to e60a654 Compare January 3, 2025 20:52

This comment has been minimized.

Sign in to view

add m68k-unknown-none-elf target

2287491

knickish force-pushed the m68k_unknown_none branch from e60a654 to 2287491 Compare January 3, 2025 21:09

workingjubilee assigned workingjubilee and unassigned GuillaumeGomez Jan 3, 2025

knickish marked this pull request as ready for review January 3, 2025 21:27

This comment has been minimized.

Sign in to view

workingjubilee requested changes Jan 3, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2025

Apply suggestions from workingjubilee's code review

139ca10

Co-authored-by: Jubilee <workingjubilee@gmail.com>

This comment has been minimized.

Sign in to view

change to static relocation model

ff7f818

workingjubilee approved these changes Jan 5, 2025

View reviewed changes

Remove other maintainers

f985a37

Co-authored-by: Jubilee <workingjubilee@gmail.com>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2025

matthiaskrgr mentioned this pull request Jan 5, 2025

Rollup of 4 pull requests #135133

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 6, 2025

bors merged commit fd98df8 into rust-lang:master Jan 6, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add m68k-unknown-none-elf target #135085

add m68k-unknown-none-elf target #135085

knickish commented Jan 3, 2025 •

edited

Loading

rustbot commented Jan 3, 2025

This comment has been minimized.

rustbot commented Jan 3, 2025

This comment has been minimized.

rustbot commented Jan 3, 2025

This comment has been minimized.

workingjubilee commented Jan 3, 2025

knickish commented Jan 3, 2025

workingjubilee left a comment

workingjubilee Jan 3, 2025

knickish Jan 4, 2025

workingjubilee Jan 5, 2025

workingjubilee Jan 3, 2025

This comment has been minimized.

workingjubilee left a comment

knickish commented Jan 5, 2025

workingjubilee commented Jan 5, 2025

bors commented Jan 5, 2025

knickish commented Jan 5, 2025

bors commented Jan 6, 2025

bors commented Jan 6, 2025

	[target.m68k-unknown-none-elf]
	# there is no easily available non-linux m68k linker, so just use the linux one
	linker = "m68k-linux-gnu-ld"

add m68k-unknown-none-elf target #135085

add m68k-unknown-none-elf target #135085

Conversation

knickish commented Jan 3, 2025 • edited Loading

rustbot commented Jan 3, 2025

This comment has been minimized.

rustbot commented Jan 3, 2025

This comment has been minimized.

rustbot commented Jan 3, 2025

This comment has been minimized.

workingjubilee commented Jan 3, 2025

knickish commented Jan 3, 2025

workingjubilee left a comment

Choose a reason for hiding this comment

workingjubilee Jan 3, 2025

Choose a reason for hiding this comment

knickish Jan 4, 2025

Choose a reason for hiding this comment

workingjubilee Jan 5, 2025

Choose a reason for hiding this comment

workingjubilee Jan 3, 2025

Choose a reason for hiding this comment

This comment has been minimized.

workingjubilee left a comment

Choose a reason for hiding this comment

knickish commented Jan 5, 2025

workingjubilee commented Jan 5, 2025

bors commented Jan 5, 2025

knickish commented Jan 5, 2025

bors commented Jan 6, 2025

bors commented Jan 6, 2025

knickish commented Jan 3, 2025 •

edited

Loading