Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: Apply a clearer naming convention to many of the test steps #135071

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Jan 3, 2025

Hopefully this does a better job of helping contributors understand what each step does, at a glance.


Original Zulip thread

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 3, 2025
@Zalathar
Copy link
Contributor Author

Zalathar commented Jan 3, 2025

@rustbot experimental
r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2025

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@onur-ozkan
Copy link
Member

Please assign/ping me once it's ready.

@bors
Copy link
Contributor

bors commented Jan 4, 2025

☔ The latest upstream changes (presumably #135086) made this pull request unmergeable. Please resolve the merge conflicts.

This helper function is used by the test step type that contained it, but it is
also used by other miri-related steps.
@rust-log-analyzer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants