-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for 1.84.0 #134568
Release notes for 1.84.0 #134568
Conversation
This comment has been minimized.
This comment has been minimized.
(cc @alex-semenyuk @joshtriplett @traviscross as you were interested in reviewing relnotes) |
<a id="1.84.0-Internal-Changes"></a> | ||
- [The syntax `&pin (mut|const) T` is now parsed as a type which in theory could effect macro expansion results in some edge cases](https://github.com/rust-lang/rust/pull/130635#issuecomment-2375462821) | ||
- [Legacy const generic arguments are no longer permitted to declare items or bodies (such as closures, inline consts, or async blocks). This does not effect normal usages of const generics in any way.](https://github.com/rust-lang/rust/pull/130443#issuecomment-2445678945) | ||
- The `wasm32-unknown-emscripten` target's binary release of the standard library is now [built with the latest emsdk 3.1.68](https://github.com/rust-lang/rust/pull/131533), which fixes an ABI-incompatibility with Emscripten >= 3.1.42. If you are locally using a version of emsdk with an incompatible ABI (e.g. before 3.1.42 or a future one), you should build your code with `-Zbuild-std` to ensure that `std` uses the correct ABI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and again compat notes (i guess the anchor tag above was misplaced)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this comment, the Emscripten version is still the same as before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@workingjubilee can you confirm whether this needs to be removed from relnotes?
LGTM. Made a few suggestions. |
Pushed a fix for the remaining items, including this in the 1.84 release and approving the PR. @bors r+ rollup |
Release notes for 1.84.0 cc `@rust-lang/release` r? `@Mark-Simulacrum`
Rollup of 9 pull requests Successful merges: - rust-lang#131830 (Add support for wasm exception handling to Emscripten target) - rust-lang#132345 (Improve diagnostics for `HostEffectPredicate` in the new solver) - rust-lang#134568 (Release notes for 1.84.0) - rust-lang#134744 (Don't ice on bad transmute in typeck in new solver) - rust-lang#135090 (Suggest to replace tuple constructor through projection) - rust-lang#135116 (rustdoc: Fix mismatched capitalization in sidebar) - rust-lang#135126 (mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor) - rust-lang#135139 ([generic_assert] Constify methods used by the formatting system) - rust-lang#135170 (Update triagebot.toml: celinval vacation is over) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#134568 - BoxyUwU:relnotes_1_84, r=pietroalbini Release notes for 1.84.0 cc ``@rust-lang/release`` r? ``@Mark-Simulacrum``
- [Move `<float>::copysign`, `<float>::abs`, `<float>::signum` to `core`](https://github.com/rust-lang/rust/pull/131304) | ||
- [Add `LowerExp` and `UpperExp` implementations to `NonZero`](https://github.com/rust-lang/rust/pull/131377) | ||
- [Implement `FromStr` for `CString` and `TryFrom<CString>` for `String`](https://github.com/rust-lang/rust/pull/130608) | ||
- [`std::os::darwin` has been made public](https://github.com/rust-lang/rust/pull/130635) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong PR linked, it should be #123723 instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #135252 with the fix. Unfortunately we already built the stable release (in preparation for the release tomorrow), and unless a critical bug happens (requiring a rebuild) the relnotes packaged with the stable release will not include the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #135252 with the fix. Unfortunately we already built the stable release (in preparation for the release tomorrow), and unless a critical bug happens (requiring a rebuild) the relnotes packaged with the stable release will not include the fix.
I found it while looking at https://releases.rs page. will be fixed included for it?
cc @rust-lang/release r? @Mark-Simulacrum