Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations #134523

dingxiangfei2009 · 2024-12-19T16:46:58Z

This patch enlarges the scope where the tail-expr-drop-order lint applies, so that all locals involved in tail expressions are inspected. This is necessary to run borrow-checking to capture the cases where it used to compile under Edition 2021 but is not going to pass borrow-checking from Edition 2024 onwards.

The way it works is to inspect each BID against the set of borrows that are still live. If the local involved in BID has a borrow index which happens to be live as well at the location of this BID statement, in the future this will be a borrow-checking violation. The lint will fire in this case.

compiler-errors · 2024-12-19T16:50:37Z

compiler/rustc_borrowck/src/lib.rs

@@ -994,6 +997,23 @@ impl<'a, 'tcx> MirBorrowckCtxt<'a, '_, 'tcx> {
        }
    }

+    fn maybe_polonius_borrows_in_scope<'s>(


why does this mention polonius at all? why isn't this just called borrows_in_scope?

Yes, let's.

I am tucking the comment into this function, too.

compiler/rustc_borrowck/src/lib.rs

dingxiangfei2009 · 2024-12-19T21:29:42Z

@bors try

bors · 2024-12-19T21:30:53Z

⌛ Trying commit 0a77622 with merge 9b5e8b1...

…t-2, r=<try> Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations Fix rust-lang#132861 r? `@nikomatsakis` cc `@compiler-errors` This patch enlarges the scope where the `tail-expr-drop-order` lint applies, so that all locals involved in tail expressions are inspected. This is necessary to run borrow-checking to capture the cases where it used to compile under Edition 2021 but is not going to pass borrow-checking from Edition 2024 onwards. The way it works is to inspect each BID against the set of borrows that are still live. If the local involved in BID has a borrow index which happens to be live as well at the location of this BID statement, in the future this will be a borrow-checking violation. The lint will fire in this case.

dingxiangfei2009 · 2024-12-19T21:45:21Z

I have prepared the following craterbot message.

@craterbot run start=master#11663cd3bfefef7d34e8f0892c250bf698049392 end=try#9b5e8b16bd1c4acf4cf8e6880368314cf021a987 mode=build-only +rustflags=-Dtail-expr-drop-order

I would like to check the difference in lint effects with -Dtail-expr-drop-order before and after, to see if there is any false positives and negatives.
build-only is required, because Always run tail_expr_drop_order lint in promoted MIR query #134493 is still not on master yet. Otherwise, we could use check-only for the experiment.

Shall we double-check and give this a go afterwards? Big thanks!

craterbot · 2024-12-19T21:45:23Z

🔒 Error: you're not allowed to interact with this bot.

🔑 If you are a member of the Rust team and need access, add yourself to the whitelist.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

…-run, r=<try> Crater run for `tail-expr-drop-order` This is experiment for rust-lang#134523

bors · 2024-12-19T23:14:09Z

☀️ Try build successful - checks-actions
Build commit: 9b5e8b1 (9b5e8b16bd1c4acf4cf8e6880368314cf021a987)

lqd · 2024-12-20T08:13:53Z

A perf run shouldn't show anything since this shouldn't be enabled by default. However, some of these previous PRs have been unexpected regressions, let's check.

@rust-timer build 9b5e8b1

rust-timer · 2024-12-20T09:58:10Z

Finished benchmarking commit (9b5e8b1): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.451s -> 768.407s (-0.14%)
Artifact size: 330.39 MiB -> 330.40 MiB (0.00%)

compiler-errors · 2024-12-31T19:02:45Z

@craterbot run start=master#11663cd3bfefef7d34e8f0892c250bf698049392+rustflags=-Dtail-expr-drop-order end=try#9b5e8b16bd1c4acf4cf8e6880368314cf021a987+rustflags=-Dtail-expr-drop-order mode=build-only

craterbot · 2024-12-31T19:02:56Z

👌 Experiment pr-134523 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-12-31T19:03:03Z

🚧 Experiment pr-134523 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-01-01T12:46:44Z

🎉 Experiment pr-134523 is completed!
📊 35438 regressed and 36 fixed (561988 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Skgland · 2025-01-01T16:27:48Z

I ran https://github.com/Skgland/Crater-Analysis to classify the build failed (unknown) regressions.

31091 contain error: internal compiler error: so are likly ICEs, from a small sample these are all in dependencies of the tested crate so likely not classified as a deps breakage due to the problem I am trying to fix in rust-lang/crater#758 .

85 failures appear to be due to running out of disk space,
either containing no space left on device or in one instance collect2: fatal error: ld terminated with signal 7 [Bus error]

Full report

Regressed: 35438
build failed(unknown): 31257
----------------------------------
Results:
E0277: 3
E0308: 3
E0422: 1
E0463: 1
E0557: 1
E0635: 28
compile_error!: 1
delimiter missmatch: 2
ice: 31091
include_bytes-missing-file: 7
include_str-missing-file: 11
linker-bus-error: 1
linker-missing-library: 18
linker-undefined-symbol: 7
missing-env-var: 1
no-space: 84
----------------------------------
sum: 31260
others: 16
----------------------------------
[
    (
        "Flying-Toast.lang.9586e323c23abf9a57dc074d09470eac07f59259",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/Flying-Toast.lang",
    ),
    (
        "JanBerktold.jute-rust.0a9a534599efa22a7c317c1b9963ac2438ac028b",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/JanBerktold.jute-rust",
    ),
    (
        "KavinduShamalka.rust_addnames.a7aeddf247ddc1e9cc4c357a8d229bd3ea69de59",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/KavinduShamalka.rust_addnames",
    ),
    (
        "Wopple.bookcase-rs.ce12f79a71946ea65b637b34773af863f1c034fd",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/Wopple.bookcase-rs",
    ),
    (
        "hardglitch.xmath.bda74b1d575c7c65e13558c361f26947597295aa",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/hardglitch.xmath",
    ),
    (
        "irreducible-io.term-rewriting.546119b6ecbd8ef8c0270bc7893e28d3286384e1",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/irreducible-io.term-rewriting",
    ),
    (
        "kirisaki.jit-compiler.5ceb89cb2a39b0f5cfe69ae1cb7944580f41eb89",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/kirisaki.jit-compiler",
    ),
    (
        "meddion.fugue.9ad7c4b881efcb66a6edde1681a01aadc4a12142",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/meddion.fugue",
    ),
    (
        "mii443.breakout-checker.62e4dabd9f7940cbf0bed01793284cf1bfe20b75",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/mii443.breakout-checker",
    ),
    (
        "raviqqe.stak.d6fa9052b0eea9e9276da15a1ac60e06b251ce1e",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/raviqqe.stak",
    ),
    (
        "scupit.gcmake-rust.50476479f7776605d30e7f1a40026c3a13e85d7b",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/scupit.gcmake-rust",
    ),
    (
        "ssav7912.rust-FreeD.6f1bbd038d6746ae06276034375dcba78453bef3",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/gh/ssav7912.rust-FreeD",
    ),
    (
        "bookcase_alloc-0.0.2",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/reg/bookcase_alloc-0.0.2",
    ),
    (
        "crypto-brainfuck-0.2.0",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/reg/crypto-brainfuck-0.2.0",
    ),
    (
        "protobuf3-2.27.2",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/reg/protobuf3-2.27.2",
    ),
    (
        "vec-with-gaps-0.7.0",
        "master%2311663cd3bfefef7d34e8f0892c250bf698049392%2Brustflags=-Dtail-expr-drop-order/reg/vec-with-gaps-0.7.0",
    ),
]

compiler-errors · 2025-01-04T02:19:32Z

@bors try

Need to re-run crater after #134575 was merged

craterbot · 2025-01-04T20:08:10Z

🚧 Experiment pr-134523-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-01-05T17:09:29Z

🎉 Experiment pr-134523-1 is completed!
📊 984 regressed and 46 fixed (563652 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Skgland · 2025-01-05T18:09:27Z

I ran https://github.com/Skgland/Crater-Analysis to classify the build failed (unknown) regressions.

Mostly Cycle Detection Errors, some running out of disk space, two ices and some other problems.

ICEs

Others:

rustc stack overflow
2x error: a temporary value will be dropped here before the execution exits the block in Edition 2024, which will raise borrow checking error in dependencies
3x (c)make can't build something due to some missing file
3x linking fails due to missing file
cmake cannot create directory
docker no such file or directory

Full report

Regressed: 984
build failed(unknown): 527
----------------------------------
Results:
E0391: 388
ice: 2
no-space: 126
----------------------------------
sum: 516
others: 11
----------------------------------
[
    (
        "JakeDawkins.graphql-client-302-repro.0378a702e84d04a3d3a7b20fdfbbf3ce2d2e728c",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/JakeDawkins.graphql-client-302-repro",
    ),
    (
        "MoAlyousef.objectif.bd283ccd33e664b22fada4311f438c0e69d0ca40",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/MoAlyousef.objectif",
    ),
    (
        "dbydd.dawdle-todo-backend.fb1a455e344738cc2aca38fc7cf62f8a70314619",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/dbydd.dawdle-todo-backend",
    ),
    (
        "gnicod.earthel.d3fd147b82db0c7c034402ec6db1c9649b2cfaf5",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/gnicod.earthel",
    ),
    (
        "jhbruhn.ics-adapter.300a22f5ea1558967c8a8d1bd873c02a779ceffd",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/jhbruhn.ics-adapter",
    ),
    (
        "lfn3.pyru-graphql.47e488e25b1ace40f22401b90fd65dcbf2cbfe05",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/lfn3.pyru-graphql",
    ),
    (
        "llpghn.mqtt_monitor.88cd673821c0784719c85a29003670e138c4d85a",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/llpghn.mqtt_monitor",
    ),
    (
        "vasily-kirichenko.DropTest.9e4abfe0738df924002113d8859c50ea21cdd04e",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/gh/vasily-kirichenko.DropTest",
    ),
    (
        "dbus-executor-0.1.0",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/reg/dbus-executor-0.1.0",
    ),
    (
        "ministo-0.1.0",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/reg/ministo-0.1.0",
    ),
    (
        "wordexp-0.1.0",
        "try%2345e7e02865cae718624ebeb3feed6d2f7848b800%2Brustflags=-Dtail-expr-drop-order/reg/wordexp-0.1.0",
    ),
]

rustbot · 2025-01-05T19:12:56Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

compiler-errors · 2025-01-05T19:13:01Z

@bors try

…t-2, r=<try> Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations Fix rust-lang#132861 r? `@nikomatsakis` cc `@compiler-errors` This patch enlarges the scope where the `tail-expr-drop-order` lint applies, so that all locals involved in tail expressions are inspected. This is necessary to run borrow-checking to capture the cases where it used to compile under Edition 2021 but is not going to pass borrow-checking from Edition 2024 onwards. The way it works is to inspect each BID against the set of borrows that are still live. If the local involved in BID has a borrow index which happens to be live as well at the location of this BID statement, in the future this will be a borrow-checking violation. The lint will fire in this case.

bors · 2025-01-05T19:14:12Z

⌛ Trying commit 4749325 with merge 214d5c94d03280918aa7845a8377fe60924de7b4...

bors · 2025-01-05T21:01:55Z

☀️ Try build successful - checks-actions
Build commit: 214d5c9 (214d5c94d03280918aa7845a8377fe60924de7b4)

compiler-errors · 2025-01-05T21:12:06Z

@craterbot run start=master#dcfa38fe234de9304169afc6638e81d0dd222c06+rustflags=-Dtail-expr-drop-order end=try#214d5c94d03280918aa7845a8377fe60924de7b4+rustflags=-Dtail-expr-drop-order mode=check-only

craterbot · 2025-01-05T21:12:21Z

👌 Experiment pr-134523-2 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

potential violations

Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>

…checking

compiler-errors · 2025-01-05T21:17:20Z

I believe I've fixed the ICEs and the cycle errors, and I'll rerun crater on just the subset of failing crates.

@craterbot crates=https://crater-reports.s3.amazonaws.com/pr-134523-1/retry-regressed-list.txt

craterbot · 2025-01-05T21:17:24Z

📝 Configuration of the pr-134523-2 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

…=chenyukang A few borrowck tweaks to improve 2024 edition migration lints See first two commits' changes to test outputs. Test coverage in this area is kinda weak, but I think it affects more cases than this (like the craters that will begin to trigger the `tail_expr_drop_order` tests in rust-lang#134523). Third commit is a drive-by change that removes a deref hack from `UseSpans` which doesn't really improve diagnostics much.

rustbot assigned nikomatsakis Dec 19, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2024

dingxiangfei2009 force-pushed the issue-130836-attempt-2 branch from beada15 to 054769b Compare December 19, 2024 16:50

compiler-errors reviewed Dec 19, 2024

View reviewed changes

lqd reviewed Dec 19, 2024

View reviewed changes

compiler/rustc_borrowck/src/lib.rs Outdated Show resolved Hide resolved

nikomatsakis approved these changes Dec 19, 2024

View reviewed changes

dingxiangfei2009 mentioned this pull request Dec 19, 2024

Crater run for tail-expr-drop-order #134537

Draft

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024

Auto merge of rust-lang#134537 - dingxiangfei2009:issue-132861-crater…

5b4a9ad

…-run, r=<try> Crater run for `tail-expr-drop-order` This is experiment for rust-lang#134523

traviscross added the L-tail_expr_drop_order Lint: tail_expr_drop_order label Dec 19, 2024

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2024

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 1, 2025

compiler-errors force-pushed the issue-130836-attempt-2 branch from 0a77622 to 2daeb51 Compare January 4, 2025 02:16

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 5, 2025

compiler-errors force-pushed the issue-130836-attempt-2 branch from 2daeb51 to 4749325 Compare January 5, 2025 19:12

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2025

dingxiangfei2009 and others added 5 commits January 5, 2025 21:16

run borrowck tests on BIDs and emit tail-expr-drop-order lints for

1822d27

potential violations

apply suggestions on fn name

1fa2603

remove an extraneous comment

1c21f71

Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>

Don't create cycles by normalizing opaques defined in the body we're …

52c487b

…checking

Don't do AccessDepth::Drop for types with no drop impl

6a9b44c

compiler-errors force-pushed the issue-130836-attempt-2 branch from 4749325 to 4072f44 Compare January 5, 2025 21:16

compiler-errors added 3 commits January 6, 2025 03:17

Improve span when temporary receiver is dropped in edition 2024

4d68466

Improve find_self_call with reborrowed receiver

05bc68f

Try to explain borrow for tail expr temporary drop order change in 2024

a6c3f8e

compiler-errors mentioned this pull request Jan 6, 2025

A few borrowck tweaks to improve 2024 edition migration lints #135147

Open

compiler-errors force-pushed the issue-130836-attempt-2 branch from 4072f44 to a6c3f8e Compare January 6, 2025 06:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations #134523

Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations #134523

dingxiangfei2009 commented Dec 19, 2024

compiler-errors Dec 19, 2024

dingxiangfei2009 Dec 19, 2024

dingxiangfei2009 commented Dec 19, 2024

bors commented Dec 19, 2024

dingxiangfei2009 commented Dec 19, 2024

craterbot commented Dec 19, 2024

bors commented Dec 19, 2024

lqd commented Dec 20, 2024

This comment has been minimized.

rust-timer commented Dec 20, 2024

compiler-errors commented Dec 31, 2024

craterbot commented Dec 31, 2024

craterbot commented Dec 31, 2024

craterbot commented Jan 1, 2025

Skgland commented Jan 1, 2025 •

edited

Loading

compiler-errors commented Jan 4, 2025

craterbot commented Jan 4, 2025

craterbot commented Jan 5, 2025

Skgland commented Jan 5, 2025

rustbot commented Jan 5, 2025

compiler-errors commented Jan 5, 2025

bors commented Jan 5, 2025

This comment has been minimized.

bors commented Jan 5, 2025

compiler-errors commented Jan 5, 2025

craterbot commented Jan 5, 2025

compiler-errors commented Jan 5, 2025

craterbot commented Jan 5, 2025

Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations #134523

Are you sure you want to change the base?

Run borrowck tests on BIDs and emit tail-expr-drop-order lints for violations #134523

Conversation

dingxiangfei2009 commented Dec 19, 2024

compiler-errors Dec 19, 2024

Choose a reason for hiding this comment

dingxiangfei2009 Dec 19, 2024

Choose a reason for hiding this comment

dingxiangfei2009 commented Dec 19, 2024

bors commented Dec 19, 2024

dingxiangfei2009 commented Dec 19, 2024

craterbot commented Dec 19, 2024

bors commented Dec 19, 2024

lqd commented Dec 20, 2024

This comment has been minimized.

rust-timer commented Dec 20, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

compiler-errors commented Dec 31, 2024

craterbot commented Dec 31, 2024

craterbot commented Dec 31, 2024

craterbot commented Jan 1, 2025

Skgland commented Jan 1, 2025 • edited Loading

compiler-errors commented Jan 4, 2025

craterbot commented Jan 4, 2025

craterbot commented Jan 5, 2025

Skgland commented Jan 5, 2025

rustbot commented Jan 5, 2025

compiler-errors commented Jan 5, 2025

bors commented Jan 5, 2025

This comment has been minimized.

bors commented Jan 5, 2025

compiler-errors commented Jan 5, 2025

craterbot commented Jan 5, 2025

compiler-errors commented Jan 5, 2025

craterbot commented Jan 5, 2025

Skgland commented Jan 1, 2025 •

edited

Loading