Remove -Zinline-in-all-cgus and clean up tests/codegen-units/ #133929
Conversation
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
remove-inline-in-all-cgus
branch
from
9827f7e to
b2b3983
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
remove-inline-in-all-cgus
branch
from
b2b3983 to
5dd9c96
Compare
saethlin
changed the title
saethlin
force-pushed
the
remove-inline-in-all-cgus
branch
from
5dd9c96 to
3db04a3
Compare
|
This PR modifies cc @jieyouxu |
There was a problem hiding this comment.
I can only comment on the compiler/ changes and the run-make test removal, which LGTM. The actual codegen-units test diffs is probably better suited for @nnethercote to review after their vacation.
There was a problem hiding this comment.
Thanks for adding these docss 💙
| ``` | ||
| MONO_ITEM <item> @@ <cgu name>[<linkage>] <other cgu name>[<linkage in other cgu>] | ||
| ``` | ||
| DO NOT add tests to this suite that use `-Zprint-mono-items=eager`, that flag changes the way that MonoItem collection works in rather fundamental ways that are otherwise only used by `-Clink-dead-code`, and thus the MonoItems collected and their linkage under `-Zprint-mono-items=eager` does not correlate very well with normal compilation behavior. |
There was a problem hiding this comment.
Remark: almost makes me think this should be a separate codegen-units-partitioning suite, which bans -Zprint-mono-items=eager in compile-flags, but anyway.
jieyouxu
added
the
A-testsuite
Implementation of rust-lang/compiler-team#814
I've taken some liberties with cleaning up the CGU partitioning tests, because that's the only place this flag was used and also mattered. I've often fought a lot with the contents of
tests/codegen-unitsand it has never been clear to me when a test failure indicates a problem with my changes as opposed to a test just needing to be manually blessed. Hopefully the combination of the new README, new comments, and using-Zprint-mono-items=lazyin the partitioning tests improves that.I've also deleted some of the
tests/run-make/sepcomptests. I think all the "sepcomp" tests have been obviated for years by better-designed (less flaky, clearer failures) test suites, but here I'm just deleting the ones I'm confident in.