Change rolling average window to all frames #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
approved these changes
Dec 6, 2024
src/video.rs
Outdated
| avg = avg + (score.1 - avg) / (min(results.len(), 10) as f64); | ||
| progress.set_message(format!(", avg: {:.1$}", avg, 2)); | ||
| rolling_mean = rolling_mean + (score.1 - rolling_mean) / (results.len() as f64); | ||
| progress.set_message(format!(", mean: {:.1$}", rolling_mean, 2)); |
There was a problem hiding this comment.
It's a bit confusing to use a parameter for the width here (i.e. :.1$) when we can just use a constant :.2:
Suggested change
| progress.set_message(format!(", mean: {:.1$}", rolling_mean, 2)); | |
| progress.set_message(format!(", mean: {rolling_mean:.2}")); |
There was a problem hiding this comment.
I didn't even know it was possible this way, I should really read the rust docs on formatting strings...
There was a problem hiding this comment.
Do you want to include this change in the PR? It might look a bit weird with me already approving, but I think this is an improvement.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the average window to all frames, instead of the last 10 frames.
I believe this to be better than before, because the average wont be impacted as much. It should give the user a more meaningful insight on overall quality during computation.
The value is also essentially the mean, so I have renamed it.