Remove mention of group(_) from error messages

runtimeverification · Feb 12, 2024 · 1791019 · 1791019
1 parent 0f086cd
commit 1791019
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 16 deletions.
diff --git a/k-distribution/tests/regression-new/checks/checkModuleAtts.k.out b/k-distribution/tests/regression-new/checks/checkModuleAtts.k.out
@@ -1,9 +1,15 @@
+[Error] Compiler: Module cannot have the following attributes: [group]
+	Source(checkModuleAtts.k)
+	Location(2,1,3,10)
+	  .	v~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+	2 |	module CHECKMODULEATTS [foo, group(bar), baz]
+	3 |	endmodule
+	  .	~~~~~~~~^
 [Error] Compiler: Unrecognized attributes: [baz, foo]
-Hint: User-defined groups can be added with the group(_) attribute.
 	Source(checkModuleAtts.k)
 	Location(2,1,3,10)
 	  .	v~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 	2 |	module CHECKMODULEATTS [foo, group(bar), baz]
 	3 |	endmodule
 	  .	~~~~~~~~^
-[Error] Compiler: Had 1 structural errors.
+[Error] Compiler: Had 2 structural errors.
diff --git a/k-distribution/tests/regression-new/pedanticAttributes/test.k.out b/k-distribution/tests/regression-new/pedanticAttributes/test.k.out
@@ -1,11 +1,9 @@
 [Error] Compiler: Unrecognized attributes: [badAtt]
-Hint: User-defined groups can be added with the group(_) attribute.
 	Source(test.k)
 	Location(3,18,3,71)
 	3 |	  syntax Int ::= r"[\\+-]?[0-9]+" [prefer, token, prec(2), badAtt(10)]
 	  .	                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 [Error] Compiler: Unrecognized attributes: [badAtt]
-Hint: User-defined groups can be added with the group(_) attribute.
 	Source(test.k)
 	Location(4,18,4,68)
 	4 |	               | Int "+" Int [group(badAttButOkay),badAtt,function]

diff --git a/kernel/src/main/java/org/kframework/compile/GenerateSentencesFromConfigDecl.java b/kernel/src/main/java/org/kframework/compile/GenerateSentencesFromConfigDecl.java
@@ -793,12 +793,7 @@ private static Tuple2<Att.Key, String> getCellProperty(K k) {
                       .orElseThrow(
                           () ->
                               KEMException.compilerError(
-                                  "Unrecognized attribute: "
-                                      + keyToken.s()
-                                      + "\n"
-                                      + "Hint: User-defined groups can be added with the"
-                                      + " group=\"...\" attribute.",
-                                  k));
+                                  "Unrecognized property: " + keyToken.s(), k));
               if (kapp.klist().items().get(0) instanceof KToken) {
                 KToken valueToken = (KToken) kapp.klist().items().get(1);
                 if (valueToken.sort().equals(Sorts.KString())) {

diff --git a/kernel/src/main/java/org/kframework/compile/checks/CheckAtt.java b/kernel/src/main/java/org/kframework/compile/checks/CheckAtt.java
@@ -78,8 +78,7 @@ private <T extends HasAtt & HasLocation> void checkUnrecognizedAtts(T term) {
       errors.add(
           KEMException.compilerError(
               "Unrecognized attributes: "
-                  + stream(term.att().unrecognizedKeys()).map(Key::toString).sorted().toList()
-                  + "\nHint: User-defined groups can be added with the group(_) attribute.",
+                  + stream(term.att().unrecognizedKeys()).map(Key::toString).sorted().toList(),
               term));
     }
   }

diff --git a/kernel/src/main/java/org/kframework/parser/json/JsonParser.java b/kernel/src/main/java/org/kframework/parser/json/JsonParser.java
@@ -356,10 +356,7 @@ public static Att toAtt(JsonObject data) {
                             "Unrecognized attribute "
                                 + key
                                 + " found in KAST Json term when unparsing KATT: "
-                                + attMap
-                                + "\n"
-                                + "Hint: User-defined groups can be added with the group(_)"
-                                + " attribute."));
+                                + attMap));
         newAtt = newAtt.add(attKey, attMap.getString(key));
       }
     }