-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate excessive internal calls to "simplify"
#388
Draft
geo2a
wants to merge
11
commits into
main
Choose a base branch
from
georgy/no-excessive-simplification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
force-pushed
the
georgy/no-excessive-simplification
branch
from
November 28, 2023 08:42
d6b9bba
to
eff1283
Compare
geo2a
force-pushed
the
georgy/no-excessive-simplification
branch
2 times, most recently
from
November 28, 2023 11:12
0c64b08
to
0402cbd
Compare
geo2a
force-pushed
the
georgy/no-excessive-simplification
branch
from
November 28, 2023 12:21
a86abe0
to
0c85dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempt to reduce the number of expensive calls to Kore's simplifier, I've propagated the calls closer to the return points in
Proxy.hs
. We still also callsimplifyExecuteState
to detect vacuous results in the following cases:Stuck
orBranching
.Obviously, things will change dramatically after merging #389, but I think these changes still may be worth having onthe SMT integration has been merged.main
, to make it so that we can remove the remaining"simplify"
call with more confidence.