Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate excessive internal calls to "simplify" #388

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Nov 24, 2023

In attempt to reduce the number of expensive calls to Kore's simplifier, I've propagated the calls closer to the return points in Proxy.hs. We still also call simplifyExecuteState to detect vacuous results in the following cases:

  • We've finished rewriting in Booster without falling back to Kore;
  • We've finished rewriting in Kore, but did not make any steps, i.e. got Stuck or Branching.

Obviously, things will change dramatically after merging #389, but I think these changes still may be worth having on main, to make it so that we can remove the remaining "simplify" call with more confidence. the SMT integration has been merged.

@geo2a geo2a force-pushed the georgy/no-excessive-simplification branch from d6b9bba to eff1283 Compare November 28, 2023 08:42
@geo2a geo2a force-pushed the georgy/no-excessive-simplification branch 2 times, most recently from 0c64b08 to 0402cbd Compare November 28, 2023 11:12
@geo2a geo2a force-pushed the georgy/no-excessive-simplification branch from a86abe0 to 0c85dcd Compare November 28, 2023 12:21
@geo2a geo2a marked this pull request as ready for review November 28, 2023 16:26
@geo2a geo2a marked this pull request as draft December 7, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant