Fix incorrect KMap injections, received from the LLVM library #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
approved these changes
Nov 20, 2023
| mapKItemInjProp api = property $ do | ||
| let k = wrapIntTerm 1 | ||
| let v = wrapIntTerm 2 | ||
| LLVM.simplifyTerm api testDef (update k v) (SortApp "SortMapValToVal" []) === singleton k v |
There was a problem hiding this comment.
Maybe also add a test for the standard map? (although we should assume that one works 😏 )
geo2a
reviewed
Nov 21, 2023
Co-authored-by: Jost Berthold <jost.berthold@runtimeverification.com>
goodlyrottenapple
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for #321 until properly addressed upstream by runtimeverification/llvm-backend#886 . The fix involves manually adjusting an injection to the correct sort, since we know the sort of the argument for a given symbol from the
KoreDefintion, passed to the decoder.