Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter GST discarded keys in the Python harness #2679

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Filter GST discarded keys in the Python harness #2679

merged 5 commits into from
Jan 14, 2025
+68 −18

Conversation

anvacaru
Copy link
Contributor

@anvacaru anvacaru commented Jan 14, 2025 •
edited
Loading

Changes:

  • Migrating the filtering of discardKeys from driver.md to gst_to_kore.
  • Dropping the quicksort of the GST input

@anvacaru anvacaru marked this pull request as ready for review January 14, 2025 14:42
tothtamas28
tothtamas28 approved these changes Jan 14, 2025
View reviewed changes
kevm-pyk/src/kevm_pyk/gst_to_kore.py Outdated Show resolved Hide resolved
ehildenb
ehildenb approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@ehildenb ehildenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 98eac94 into master Jan 14, 2025
12 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the python_gst_handler branch January 14, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothtamas28 tothtamas28 tothtamas28 approved these changes

@ehildenb ehildenb ehildenb approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anvacaru @tothtamas28 @ehildenb