Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Remove PrimitiveObject #18995

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Lord-McSweeney
Copy link
Collaborator

@Lord-McSweeney Lord-McSweeney commented Dec 16, 2024

Supersedes #13152.

Testing on #15485 shows no significant change in its startup time.

Closes #15517.

This also refactors event dispatch code to accept an EventObject instead of a Value or Object

@torokati44 torokati44 added A-avm2 Area: AVM2 (ActionScript 3) T-refactor Type: Refactor / Cleanup labels Dec 17, 2024
@Lord-McSweeney Lord-McSweeney force-pushed the avm2-primobj-4 branch 2 times, most recently from c66ee38 to cb921ef Compare December 17, 2024 18:53
@Lord-McSweeney Lord-McSweeney added the waiting-on-review Waiting on review from a Ruffle team member label Dec 18, 2024
@Lord-McSweeney Lord-McSweeney force-pushed the avm2-primobj-4 branch 2 times, most recently from 7039dc1 to 27133cb Compare December 31, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-refactor Type: Refactor / Cleanup waiting-on-review Waiting on review from a Ruffle team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegExp valueOf returns a string instead of object
2 participants