feat: introduce the advanced publisher and subscriber #368
+88
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanYuYuan
force-pushed
the
feat/advanced-pub-sub
branch
from
e0c490f to
1f9357f
Compare
|
Update: The deadlock fix has been merged. Mark this PR as ready for review. |
…claration deadlock
Test Failure
No new failure is found. |
|
Update: bump up zenoh-cpp version to include the memory leak fix eclipse-zenoh/zenoh-cpp#363. |
|
Will rebase once #405 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we replace the
QueryingSubscriberandPublicationCache(+ a normal publisher)with the
AdvancedSubscriberandAdvancedPublisher.NOTE: A deadlock is found when undeclaring advanced subscribers. It will be fixed once eclipse-zenoh/zenoh#1685 is merged and synced with zenoh-c.