Switch to using get_system_time_in_ns() function everywhere. #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/use-ns-function
branch
from
ad561b0 to
cefbdc0
Compare
Yadunund
approved these changes
Dec 24, 2024
|
@Mergifyio backport humble jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit e7493d3) # Conflicts: # rmw_zenoh_cpp/src/detail/rmw_subscription_data.cpp
mergify bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit e7493d3) # Conflicts: # rmw_zenoh_cpp/src/detail/rmw_subscription_data.cpp
This was referenced Jan 2, 2025
Yadunund
pushed a commit
that referenced
this pull request
Jan 2, 2025
That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Yadunund
added a commit
that referenced
this pull request
Jan 2, 2025
…#354) (#380) * Switch to using get_system_time_in_ns() function everywhere. (#354) That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Add get_system_time_in_ns() Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com>
Yadunund
added a commit
that referenced
this pull request
Jan 2, 2025
…#354) (#380) * Switch to using get_system_time_in_ns() function everywhere. (#354) That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds. Signed-off-by: Chris Lalancette <clalancette@gmail.com> * Add get_system_time_in_ns() Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com>
Yadunund
added a commit
that referenced
this pull request
Jan 2, 2025
…#354) (#380) (#379) * Switch to using get_system_time_in_ns() function everywhere. (#354) That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds. * Add get_system_time_in_ns() --------- Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we have just a single place where this is defined, and everywhere can be sure they are getting the correct value in nanoseconds.