Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Double Spin in #4558 once rclcpp #2589 fixed #4567

Open
SteveMacenski opened this issue Jul 25, 2024 · 2 comments
Open

Revert Double Spin in #4558 once rclcpp #2589 fixed #4567

SteveMacenski opened this issue Jul 25, 2024 · 2 comments

Comments

@SteveMacenski
Copy link
Member

#4558 fixed our CI issues caused by ros2/rclcpp#2589. Revert once resolved and for the test case
@SteveMacenski
Copy link
Member Author

SteveMacenski commented Sep 17, 2024 •
edited
Loading

Has been merged into Jazzy and Rolling, we can revert once new binaries are cut (latest as of writing 9/17)

@tonynajjar tonynajjar mentioned this issue Dec 4, 2024
Open
@tonynajjar
Copy link
Contributor

Has been merged into Jazzy and Rolling, we can revert once new binaries are cut (latest as of writing 9/17)

Not really, there was some fix merged for the EventsExecutor but we don't use that; the general fix is still pending. Meanwhile #4784 is a backport that fixes the tests in Jazzy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonynajjar @SteveMacenski