Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP35L Support Package #535

Merged

Conversation

EricMarcil
Copy link
Contributor

Add GP35L Support Package

Add GP35L Support Package
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. One inline question.

@EricMarcil: seeing as this appears to be an L variant: are there any other variants of the GP35? If so, the support package name should drop the l.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricMarcil: could you clarify where this OPW config file came from?

Did you verify it yourself?

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Jun 28, 2023

Something else I noticed:

image

the black motors and cable and white Yaskawa lettering are a nice touch, but as you can see, the black is so black, there is no detail visible at all like this.

Notice also the rendering artefacts on other parts of the geometry: could it be the meshes have been decimated/compressed too much?

@EricMarcil
Copy link
Contributor Author

@gavanderhoorn Changed the black to dark gray. Also fixed the color of a few faces that got messed up by the decimated. It does look as if the model was a bit too decimated but that's how my original source file was. So we'll go with that for now.

Copy link
Contributor

@ted-miller ted-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on Eric's testing

@ted-miller ted-miller merged commit 9fec5ea into ros-industrial:kinetic-devel Dec 20, 2023
6 checks passed
@cjue
Copy link
Contributor

cjue commented Dec 20, 2023

seeing as this appears to be an L variant: are there any other variants of the GP35? If so, the support package name should drop the l.

Judging from this overview there is no "GP35" besides the GP35L, so package name should be fine.

@EricMarcil
Copy link
Contributor Author

seeing as this appears to be an L variant: are there any other variants of the GP35? If so, the support package name should drop the l.

On that note, most of the models ending by an L are hybrid robot with longer reach and have nothing to do with a base model with the same number. The number in the model simply indicates the resulting payload of the hybrid model. The GP35L is actually closer to a GP50 but with an extension in the upper arm to give it more reach but reduced payload to 35 kg. If we were to include it in the GP50 support package, then I think most people would not find it. So, I think that having a package named GP35L is the best solution.

@EricMarcil EricMarcil deleted the GP35L-Support-Package branch December 20, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants