Remove RWSClient members that can be local variables. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on current master. |
jontje
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes member variables from
RWSClientthat can also be local variables, as discussed in #59. Among other considerations, this can also help in makingwaitForSubscriptionEvent()andendSubscription()thread safe at some point.Note that this branches off from PR #58 to avoid a future merge conflicts. It probably makes sense to hold off reviewing this until then. The diff should be a lot smaller after #58 is merged.
I also haven't been able to test the library with these changes yet. I think I will be able to do so tommorow.