Replace deprecated cuda texture binding API #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of December 2022 with the release of CUDA 12.0, the texture binding API that was deprecated in CUDA 11.3 was removed entirely and so yak no longer compiled on systems with the most recent CUDA release. This change replaces the texture binding in yak with the more modern texture object API.
This should be non-breaking for previous CUDA releases since the texture object API was released in CUDA 5.0 which was already the minimum version for kinfu. I've tested the change using yak_ros2 on ros2 Galactic in Ubuntu 20.024 with some bag data and successfully reconstructed my target surface, so it all seems to work.