pb_download_url returns choice of browser or api download urls
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like duckdb/duckdb#8425 would add support for custom http headers to duckdb |
|
Sweet! Probably worth updating the vignette when that gets merged in, I'll leave an issue as a followup for next time I get into a piggyback-updating-spree. |
tanho63
commented
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116.
Adds handling so that pb_download_url can be more useful with private repos. Not 100% sure how the auth header would be passed in a cloud-native setup yet (might never be) but at least we can document ways to skip disk read now.