Use legend entry's option instead of object's DrawOption when deciding endcaps #17332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where legend is drawn to a different pad than the object
Test Results 18 files 18 suites 3d 23h 55m 13s ⏱️ For more details on these failures, see this check. Results for commit 6d17d1d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered the case where the legend is being drawn to a separate pad from the object, which means the
GetDrawOption()returns a blank string no matter how it was drawn in the other pad.It would surely make most sense to have the decision about endcaps be determined from the TLegendEntry option, like all the other aspects of the drawing of the legend entry.
This PR makes that change.