Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React & Redux group project: set up your Kanban board #21

Merged
merged 10 commits into from
Aug 22, 2022
Merged

Conversation

rominana
Copy link
Owner

In this project, @Hannziegel, @fahimy143, and I:

  • Created an empty repository for your group project.
  • Followed the steps described in curriculum-tools-copy-projects in order to copy the [TEMPLATE] React Group Project board.
  • Opened a GitHub project (Kanban board) in our team repo.
  • Make sure that in the card titles you can see categories: Setup, Fetch data, Lists render, Actions, Conditional components, Filters.
  • Make sure that each card starts with [Xpt].
  • Each of the team members should assign themselves to the cards from all categories.

Copy link
Collaborator

@fahimy143 fahimy143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rominana , @Hannziegel ,

🔥 Highlights 🔥

  • No Linters error
  • setup is complete

we did an amazing job till now 🔥 our project is complete! There is nothing else to say other than... it's time to merge it 😎

Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@rominana rominana merged commit 8eee8f5 into development Aug 22, 2022
@BenMukebo
Copy link

BenMukebo commented Aug 22, 2022

Status: Approve 🍾 👍 🎊

Hi @rominana , @Hannziegel ,

Congratulations! 🎉 Project Approved ✅

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

To Highlight 🥇

  • Your Pull Request has:
    • Link to their GitHub project 👍🏻
    • Information about the number of people in their group 👏🏻
  • All cards are assigned to team members 🥇

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers 🥂 and Happy coding!!! 👯💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @BenMukebo when you comment so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants