Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 🏄🏽 move metrics tests to test module #47

Merged
merged 1 commit into from
Nov 27, 2024
Merged

refactor: 🏄🏽 move metrics tests to test module #47

merged 1 commit into from
Nov 27, 2024

Conversation

rodneylab
Copy link
Owner

Description

Refactor metrics apps into new TestApp to use infrastructure created for cleaner
tests.

Type of change

  • Refactor

How Has This Been Tested?

  • cargo test run with all tests passing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@rodneylab rodneylab merged commit 1b9d3f4 into main Nov 27, 2024
15 checks passed
@rodneylab rodneylab deleted the refactor__move_metrics_tests branch November 27, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rodneylab