Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ☑️ improve snapshot testing #18

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

rodneylab
Copy link
Owner

Description

Add GraphQL queries to snapshot input files, for more robust and maintainable tests.

Type of change

  • Test

How Has This Been Tested?

  • cargo test run with all tests passing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (0a36fbe) to head (f513908).

Files with missing lines Patch % Lines
src/model/tests.rs 81.81% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   86.27%   86.04%   -0.24%     
==========================================
  Files           8        8              
  Lines        1086     1096      +10     
==========================================
+ Hits          937      943       +6     
- Misses        149      153       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodneylab rodneylab merged commit 142b956 into main Nov 9, 2024
13 checks passed
@rodneylab rodneylab deleted the test__update_graphql_snapshot_testing branch November 9, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants