Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate deadlineWith and add deadlineFor instead #59

Merged
merged 1 commit into from
May 2, 2024
Merged

Deprecate deadlineWith and add deadlineFor instead #59

merged 1 commit into from
May 2, 2024

Conversation

spacey-sooty
Copy link
Contributor

@spacey-sooty spacey-sooty force-pushed the deadlinefor branch 3 times, most recently from 6004b99 to fe73346 Compare April 29, 2024 04:43
@TheTripleV
Copy link
Member

needs a test. You can copy and paste the existing deadlineWith one.

@virtuald
Copy link
Member

git-source-track information needs to be updated too, probably should add it to CI and a document for how one does that.

@spacey-sooty
Copy link
Contributor Author

needs a test. You can copy and paste the existing deadlineWith one.

Should I delete the deadlineWith one as well?

@TheTripleV
Copy link
Member

Keep it for now since its still supported

@TheTripleV TheTripleV merged commit e2a83dd into robotpy:main May 2, 2024
19 checks passed
@spacey-sooty spacey-sooty deleted the deadlinefor branch July 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacey-sooty @TheTripleV @virtuald