Fix typing of deprecated aliases #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes type hints in Pylance. The module `__getattr__` throws off its checking of what types are actually available. This hides the `__getattr__` from type checkers
auscompgeek
reviewed
Jan 18, 2024
commands2/subsystem.py
Outdated
| CommandScheduler.getInstance().registerSubsystem(instance) | ||
| return instance | ||
| if not TYPE_CHECKING: | ||
| def __new__(cls, *arg, **kwargs) -> "Subsystem": |
There was a problem hiding this comment.
This seems wrong. We should return typing.Self instead.
There was a problem hiding this comment.
I agree. But typing.Self was added in 3.11 according to https://docs.python.org/3/library/typing.html#typing.Self
There was a problem hiding this comment.
We're already using typing_extensions in command, so let's just use it here?
|
Here's what all the typehints are before this PR |
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes type hints in Pylance. The module
__getattr__throws off its checking of what types are actually available.This hides the
__getattr__from type checkers