Skip to content

Commit

Permalink
Use latest LTS Node in CI
Browse files Browse the repository at this point in the history
The README says we require the latest LTS version of Node, but actions/setup-node with ubuntu-latest appears to default to a version earlier than that. I'd like to make use of a feature (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicodeSets) available only since Node 20, which happens to be the latest LTS. So, let's get CI on the right version.
  • Loading branch information
robintown committed Jun 12, 2024
1 parent 6198ce5 commit e0fc4f0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/end-to-end-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

- name: Fetch layered build
Expand Down Expand Up @@ -119,6 +120,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"
cache-dependency-path: matrix-react-sdk/yarn.lock

Expand Down Expand Up @@ -173,6 +175,7 @@ jobs:
- uses: actions/setup-node@v4
if: inputs.skip != true
with:
node-version: lts/* # Latest LTS
cache: "yarn"

- name: Install dependencies
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/static_analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

- name: Install Deps
Expand Down Expand Up @@ -82,6 +83,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

# Does not need branch matching as only analyses this layer
Expand All @@ -99,6 +101,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

# Does not need branch matching as only analyses this layer
Expand All @@ -116,6 +119,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

# Does not need branch matching as only analyses this layer
Expand All @@ -133,6 +137,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

- name: Install Deps
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
- name: Yarn cache
uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

- name: Install Deps
Expand Down Expand Up @@ -114,6 +115,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: lts/* # Latest LTS
cache: "yarn"

- name: Run tests
Expand Down

0 comments on commit e0fc4f0

Please sign in to comment.