fixed #19 Cheerio Not Properly Handling Self Enclosed Tags

rkazakov · Jun 21, 2018 · c3fd7e7 · c3fd7e7
1 parent b149020
commit c3fd7e7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -164,7 +164,7 @@ module.exports = (html, options) => {
     const ampElement = Object.assign(element, {
       name: `amp-${element.name}`,
     });
-    $(element).replaceWith(ampElement);
+    $(element).html($(ampElement).html());
   });
 
   return $.html();

diff --git a/test/images.test.js b/test/images.test.js
@@ -33,4 +33,12 @@ describe('amp-img tag', () => {
       { cwd: __dirname.split(path.sep).pop() },
     );
   });
+
+  test('should not change element order or remove next element', () => {
+    assert(
+      '<div><p>1</p><img src="image.png" width="300" height="200"><p>2</p></div>',
+      '<div><p>1</p><amp-img src="image.png" width="300" height="200"></amp-img><p>2</p></div>',
+      { cwd: __dirname.split(path.sep).pop() },
+    );
+  });
 });