chore: bump deps #456
Merged
chore: bump deps #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-rise
requested review from
kien-rise,
0xNarumi,
mateusfigmelo and
i1i1
as code owners
i1i1
reviewed
Jan 10, 2025
| @@ -58,7 +51,7 @@ fn get_ethereum_gas_price(tx: &TxEnvelope) -> Result<U256, EthereumTransactionPa | |||
| impl PevmChain for PevmEthereum { | |||
| type Transaction = alloy_rpc_types_eth::Transaction; | |||
| type Envelope = TxEnvelope; | |||
| type BlockSpecError = EthereumBlockSpecError; | |||
| type BlockSpecError = (); | |||
There was a problem hiding this comment.
I'm a bit late to the party, but this could be std::convert::Infallible which makes Result::Err not constructable and makes functions always return Result::Ok
There was a problem hiding this comment.
Ah yes, thanks. More care and justice for pevm soon™️!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.