Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix nonce deadlock #408

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kien-rise
Copy link
Contributor

@kien-rise kien-rise commented Oct 31, 2024

Improvement from #406

Self-tested in the PEVM integration, using ERC20 and Uniswap benchmarks.

Performance Effect

There is a slight decrease in performance.

# Before
Average: x1.95
Max: x4.18
Min: x0.88

# After
Average: x1.94
Max: x4.15
Min: x0.88

The gigagas benchmark got some performance decrease too:

Benchmarking Independent Raw Transfers/Parallel:
    time:   [60.038 ms 60.205 ms 60.372 ms]
    change: [+6.3255% +6.8597% +7.3995%] (p = 0.00 < 0.05)
    Performance has regressed.

Benchmarking Independent ERC20/Parallel:
    time:   [68.304 ms 68.664 ms 69.010 ms]
    change: [+0.2251% +0.9273% +1.5822%] (p = 0.01 < 0.05)
    Change within noise threshold.

Benchmarking Independent Uniswap/Parallel:
    time:   [33.608 ms 33.654 ms 33.703 ms]
    change: [+1.3274% +1.5758% +1.8054%] (p = 0.00 < 0.05)
    Performance has regressed.

@kien-rise kien-rise force-pushed the 0159-nonce-deadlock branch from 071662d to 6f2860b Compare November 1, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant