feat: Update quil to >=0.13.2 #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 1808-quil-breaking-change |
| Testbed | ci-runner-linux |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| test/benchmarks/test_program.py::test_copy_everything_except_instructions | 📈 view plot | 9,341,260,062.00 |
| test/benchmarks/test_program.py::test_instructions | 📈 view plot | 4,084,714,232.60 |
| test/benchmarks/test_program.py::test_iteration | 📈 view plot | 4,118,027,520.60 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
|
||
| @property # type: ignore[override] | ||
| def parameters(self) -> Sequence[ParameterDesignator]: | ||
| """The parameters of the calibration.""" | ||
| return _convert_to_py_expressions(super().parameters) | ||
| return _convert_to_py_expressions(super().identifier.parameters) |
There was a problem hiding this comment.
For some reason I can't get the type stubs to agree, looks like rigetti/quil-rs#420 is resolved because the types are correct in https://github.com/rigetti/quil-rs/blob/main/quil-py/quil/instructions/__init__.pyi#L888-L897 but not when I install quil-rs==0.13.2... but, this should be the same thing and gets the test passing.
jselig-rigetti
approved these changes
Dec 11, 2024
kalzoo
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1808